-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix build for s390x and ppc64le #151
Conversation
Codecov Report
@@ Coverage Diff @@
## main #151 +/- ##
=======================================
Coverage 39.25% 39.25%
=======================================
Files 31 31
Lines 2214 2214
=======================================
Hits 869 869
Misses 1296 1296
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
New image: quay.io/netobserv/netobserv-ebpf-agent:96e75c6. It will expire after two weeks. |
There's no need to create a duplicate file to handle the different architectures. Just use generics instead. Change: to: |
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=dd3ced3 make set-agent-image |
/lgtm but might want to add a comment |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ppc64le and s390x for some reason they use
uint8
instead ofint8
for this typehttps://pkg.go.dev/syscall#Utsname
leading to this build error
Fix to create two instances of utils package based on arch check