-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1199: Socket doesn't always have valid if_index so we can't use it as key #153
Conversation
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=0cacdb9 make set-agent-image |
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
=======================================
Coverage 39.25% 39.25%
=======================================
Files 31 31
Lines 2214 2214
=======================================
Hits 869 869
Misses 1296 1296
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. |
@msherif1234: This pull request references NETOBSERV-1199 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tested pre-merge |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
its not good idea to use interface as key since linux socket can't always populate it and that will result into missing responses so just remove it from the key