Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-201: configure LogLevel and Sampling #16

Merged
merged 2 commits into from
Apr 21, 2022
Merged

NETOBSERV-201: configure LogLevel and Sampling #16

merged 2 commits into from
Apr 21, 2022

Conversation

mariomac
Copy link

It replaces the "Verbose" binary config option by "LogLevel", to match other Netobserv components.

It also adds configurable sampling rate.

The best way to test sampling is to use grafana to count the number of processed packets.

In the following image you can see the packet count during 3 differentiated periods: no sampling (100% of packets processed), sampling==2 (50% of packets processed) and sampling == 4 (25% of packets processed).

image

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #16 (e6e5cef) into main (e9b1d44) will decrease coverage by 0.07%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   43.72%   43.64%   -0.08%     
==========================================
  Files           8        8              
  Lines         478      488      +10     
==========================================
+ Hits          209      213       +4     
- Misses        253      260       +7     
+ Partials       16       15       -1     
Flag Coverage Δ
unittests 43.64% <20.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/config.go 70.73% <ø> (ø)
pkg/ebpf/tracer.go 3.59% <14.28%> (+0.40%) ⬆️
pkg/agent/agent.go 79.41% <100.00%> (ø)
pkg/exporter/grpc_proto.go 90.32% <0.00%> (+4.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b1d44...e6e5cef. Read the comment docs.

Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mariomac mariomac merged commit 1d9a9b6 into netobserv:main Apr 21, 2022
@mariomac mariomac deleted the sampling branch April 21, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants