-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shrink DNSMap if DNS not enabled to save memory #165
Shrink DNSMap if DNS not enabled to save memory #165
Conversation
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=718caf5 make set-agent-image |
Codecov Report
@@ Coverage Diff @@
## main #165 +/- ##
==========================================
- Coverage 38.82% 38.66% -0.16%
==========================================
Files 31 31
Lines 2246 2255 +9
==========================================
Hits 872 872
- Misses 1325 1334 +9
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good ! thanks @msherif1234
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shrink dnsmap to 1 entry when the feature is not enabled to optimize memory usage
![image](https://private-user-images.githubusercontent.com/12748167/256522745-d8b990c9-e5ae-4e99-9905-5b58d42242e0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0Njc5MjYsIm5iZiI6MTcyNDQ2NzYyNiwicGF0aCI6Ii8xMjc0ODE2Ny8yNTY1MjI3NDUtZDhiOTkwYzktZTVhZS00ZTk5LTk5MDUtNWI1OGQ0MjI0MmUwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDAyNDcwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNmMzFhMTcxN2M4N2M1MzQ5OWNiMDg5MWFhYWQ3NTlmZmQ4ZDAzOTkxN2U4YTc5ODBhNmIyOTQyNDM3OTY5OWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Dp2ZLBxl10jXbkSgskVIbHh6R6hoR-C1-3e6vWtfreE)
Note: I have to move code out of FlowFetcher function because lint hit complexity limit in that function