Shrink DNSMap if DNS not enabled to save memory #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=718caf5 make set-agent-image |
Codecov Report
@@ Coverage Diff @@
## main #165 +/- ##
==========================================
- Coverage 38.82% 38.66% -0.16%
==========================================
Files 31 31
Lines 2246 2255 +9
==========================================
Hits 872 872
- Misses 1325 1334 +9
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jpinsonneau
approved these changes
Jul 28, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shrink dnsmap to 1 entry when the feature is not enabled to optimize memory usage
Note: I have to move code out of FlowFetcher function because lint hit complexity limit in that function