-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1223: check Maps to make sure not nil b4 iterating #167
Conversation
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@msherif1234: This pull request references NETOBSERV-1223 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=7cf1e86 make set-agent-image |
/label qe-approved |
Codecov Report
@@ Coverage Diff @@
## main #167 +/- ##
==========================================
- Coverage 38.82% 38.63% -0.19%
==========================================
Files 31 31
Lines 2246 2257 +11
==========================================
Hits 872 872
- Misses 1325 1336 +11
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@msherif1234: This pull request references NETOBSERV-1223 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
there is some behavior difference with maps between rhel8 and rhel9
on rhel8 it seems maps not even allocated until its populated leading to this issue while in rhel9 that doesn't seem to be the case.
To be on safe side lets make sure maps pointer is != nil before doing invoking
Iterate