Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1223: check Maps to make sure not nil b4 iterating #167

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jul 31, 2023

there is some behavior difference with maps between rhel8 and rhel9
on rhel8 it seems maps not even allocated until its populated leading to this issue while in rhel9 that doesn't seem to be the case.

To be on safe side lets make sure maps pointer is != nil before doing invoking Iterate

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 31, 2023

@msherif1234: This pull request references NETOBSERV-1223 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 31, 2023
@github-actions
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:7cf1e86

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=7cf1e86 make set-agent-image

@memodi
Copy link
Contributor

memodi commented Jul 31, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #167 (b88f23b) into main (338d2b2) will decrease coverage by 0.19%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   38.82%   38.63%   -0.19%     
==========================================
  Files          31       31              
  Lines        2246     2257      +11     
==========================================
  Hits          872      872              
- Misses       1325     1336      +11     
  Partials       49       49              
Flag Coverage Δ
unittests 38.63% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/ebpf/tracer.go 0.00% <0.00%> (ø)

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 31, 2023

@msherif1234: This pull request references NETOBSERV-1223 which is a valid jira issue.

In response to this:

there is some behavior difference with maps between rhel8 and rhel9
on rhel8 it seems maps not even allocated until its populated leading to this issue while in rhel9 that doesn't seem to be the case.

To be on safe side lets make sure maps pointer is != nil before doing invoking Iterate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 1, 2023
@openshift-merge-robot openshift-merge-robot merged commit af7d59d into netobserv:main Aug 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants