-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1151: move flp decode grpc pipe to netobserv agent to avoid flp code updates #168
Conversation
@msherif1234: This pull request references NETOBSERV-1151 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 39.51% 38.27% -1.25%
==========================================
Files 31 32 +1
Lines 2394 2712 +318
==========================================
+ Hits 946 1038 +92
- Misses 1391 1615 +224
- Partials 57 59 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@msherif1234: This pull request references NETOBSERV-1151 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=313dccc make set-agent-image |
c2530eb
to
faad632
Compare
faad632
to
de61a97
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=323ef13 make set-agent-image |
de61a97
to
994b427
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=14e6221 make set-agent-image |
Ran the full-suite of automated regression tests for the above eBPF image. All except SCTP test-case passed(which is known issue, being investigated; issue unrelated to this PR). 204887 |
Also regression tested the PacketDrop feature and its working as expected! |
/label qe-approved |
994b427
to
17580e2
Compare
17580e2
to
5cc2d04
Compare
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
5cc2d04
to
d0a6445
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, decode_protobuf.go
is up to date right now. I would suggest to merge to avoid having to sync it again and again 😸
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
move FLP grpc decode logic to the agent to just limit flp to pkg update w/o need to do any code changes