NETOBSERV-1283: Make ifaces watcher netns aware #171

msherif1234 · 2023-08-28T15:06:05Z

today netobserv agent only subscribe to watch interface in default netns
for PODs with VF SRIOV interfaces they only show in custom netns made them invisible to network observability to fix this netobserv agent interface manager component needs to netns aware
needs netobserv/network-observability-operator#406 to setup netns mount

codecov · 2023-08-28T15:12:33Z

Codecov Report

Patch coverage: 40.54% and project coverage change: -0.02% ⚠️

Comparison is base (6d9d2e7) 38.60% compared to head (cfeb767) 38.58%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   38.60%   38.58%   -0.02%     
==========================================
  Files          31       31              
  Lines        2259     2340      +81     
==========================================
+ Hits          872      903      +31     
- Misses       1338     1383      +45     
- Partials       49       54       +5

Flag	Coverage Δ
unittests	`38.58% <40.54%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
pkg/ebpf/tracer.go	`0.00% <0.00%> (ø)`
pkg/ifaces/informer.go	`0.00% <0.00%> (ø)`
pkg/ifaces/watcher.go	`58.46% <48.38%> (-23.36%)`	⬇️

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

msherif1234 · 2023-08-28T15:14:48Z

/ok-to-test

github-actions · 2023-08-28T15:16:40Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:a960c44

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=a960c44 make set-agent-image

msherif1234 · 2023-08-28T16:21:14Z

/ok-to-test

github-actions · 2023-08-28T16:22:55Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:e401fa0

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=e401fa0 make set-agent-image

openshift-ci-robot · 2023-08-29T16:43:28Z

@msherif1234: This pull request references Jira Issue OCPBUGS-17785, which is invalid:

expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

today netobserv agent only subscribe to watch interface in default netns
for PODs with VF SRIOV interfaces they only show in netns make them invisible to network observability

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

msherif1234 · 2023-08-29T16:45:40Z

/jira refresh

openshift-ci-robot · 2023-08-29T16:45:52Z

@msherif1234: This pull request references Jira Issue OCPBUGS-17785, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @memodi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

msherif1234 · 2023-08-29T20:00:57Z

/ok-to-test

msherif1234 · 2023-08-29T20:02:30Z

/ok-to-test

github-actions · 2023-08-29T20:04:34Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:e26f1d5

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=e26f1d5 make set-agent-image

msherif1234 · 2023-08-29T20:25:11Z

/ok-to-test

msherif1234 · 2023-08-29T20:36:37Z

/ok-to-test

github-actions · 2023-09-02T11:23:55Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:652a4b6

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=652a4b6 make set-agent-image

openshift-ci-robot · 2023-09-02T20:11:37Z

@msherif1234: This pull request references Jira Issue OCPBUGS-17785, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @memodi

In response to this:

today netobserv agent only subscribe to watch interface in default netns
for PODs with VF SRIOV interfaces they only show in custom netns made them invisible to network observability to fix this netobserv agent interface manager component needs to netns aware

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bn222 · 2023-09-04T14:44:26Z

pkg/ifaces/watcher.go

-		if link.Flags&(syscall.IFF_UP|syscall.IFF_RUNNING) != 0 {
+		iface := Interface{Name: attrs.Name, Index: attrs.Index, NetNS: netnsHandle}
+		w.mutex.Lock()
+		if link.Flags&(syscall.IFF_UP|syscall.IFF_RUNNING) != 0 && attrs.OperState == netlink.OperUp {


For the record attrs.OperState == netlink.OperUp is needed to avoid calling EventAdded too soon since it will come up with OperState set to Down first.

bn222 · 2023-09-04T14:44:53Z

pkg/ifaces/watcher.go

+
+func getNetNSHandles(ctx context.Context) ([]netns.NsHandle, error) {
+	log := logrus.WithField("component", "ifaces.Watcher")
+	out, err := exec.CommandContext(ctx, "ls", "-lt", "/var/run/netns/").Output()


Can we use proper golang functions for this instead of exec.CommandContext? Maybe ioutil.ReadDir

good point swtiched to os.ReadDir() Thanks!!

bn222 · 2023-09-04T14:47:22Z

Added a small comment. Otherwise LGTM

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

msherif1234 · 2023-09-04T15:21:37Z

/ok-to-test

github-actions · 2023-09-04T15:22:47Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:2ef08da

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=2ef08da make set-agent-image

jotak · 2023-09-06T14:10:43Z

/lgtm

msherif1234 · 2023-09-06T14:18:03Z

@memodi can u pls do sanity check for this PR with the operator netobserv/network-observability-operator#406 we agreed to make sure it doesn't introduce regression and sriov testing can be done after the merge

openshift-ci-robot · 2023-09-06T18:29:56Z

@msherif1234: This pull request references Jira Issue OCPBUGS-17785, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @memodi

In response to this:

today netobserv agent only subscribe to watch interface in default netns
for PODs with VF SRIOV interfaces they only show in custom netns made them invisible to network observability to fix this netobserv agent interface manager component needs to netns aware
needs netobserv/network-observability-operator#406 to setup netns mount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-09-07T07:21:42Z

@msherif1234: This pull request references NETOBSERV-1283 which is a valid jira issue.

In response to this:

today netobserv agent only subscribe to watch interface in default netns
for PODs with VF SRIOV interfaces they only show in custom netns made them invisible to network observability to fix this netobserv agent interface manager component needs to netns aware
needs netobserv/network-observability-operator#406 to setup netns mount

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

memodi · 2023-09-07T21:29:35Z

SRIOV testing passed, currently running select e2e regression tests with Operator PR netobserv/network-observability-operator#406

memodi · 2023-09-07T23:57:18Z

/label qe-approved

jotak · 2023-09-08T07:59:10Z

thanks @msherif1234 @bn222 @memodi !
/approve

openshift-ci · 2023-09-08T07:59:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 28, 2023

msherif1234 force-pushed the fix_netns branch from fc79649 to 0ee27ba Compare August 28, 2023 15:50

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 28, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 28, 2023

msherif1234 changed the title ~~Make ifaces watcher netns aware~~ OCPBUGS-17785: Make ifaces watcher netns aware Aug 29, 2023

openshift-ci-robot added jira/severity-important jira/valid-reference jira/invalid-bug labels Aug 29, 2023

openshift-ci-robot added jira/valid-bug and removed jira/invalid-bug labels Aug 29, 2023

openshift-ci bot requested a review from memodi August 29, 2023 16:46

msherif1234 force-pushed the fix_netns branch from 0ee27ba to ceaca65 Compare August 29, 2023 20:00

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 29, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 29, 2023

msherif1234 force-pushed the fix_netns branch from ceaca65 to 49df06a Compare August 29, 2023 20:24

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 29, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 29, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 2, 2023

bn222 reviewed Sep 4, 2023

View reviewed changes

msherif1234 added 2 commits September 4, 2023 11:15

Make ifaces watcher netns aware

9051afc

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

fix ebpf registering to handle different netns

cfeb767

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

msherif1234 force-pushed the fix_netns branch from 2b45e2f to cfeb767 Compare September 4, 2023 15:16

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 4, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 4, 2023

msherif1234 requested a review from jotak September 5, 2023 20:33

openshift-ci bot assigned jotak Sep 6, 2023

openshift-ci bot added the lgtm label Sep 6, 2023

jotak changed the title ~~OCPBUGS-17785: Make ifaces watcher netns aware~~ NETOBSERV-1283: Make ifaces watcher netns aware Sep 7, 2023

openshift-ci-robot removed jira/severity-important jira/valid-bug labels Sep 7, 2023

openshift-ci bot added the qe-approved QE has approved this pull request label Sep 7, 2023

openshift-ci bot added the approved label Sep 8, 2023

openshift-merge-robot merged commit a7d4eec into netobserv:main Sep 8, 2023
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NETOBSERV-1283: Make ifaces watcher netns aware #171

NETOBSERV-1283: Make ifaces watcher netns aware #171

msherif1234 commented Aug 28, 2023 •

edited

Loading

codecov bot commented Aug 28, 2023 •

edited

Loading

msherif1234 commented Aug 28, 2023

github-actions bot commented Aug 28, 2023

msherif1234 commented Aug 28, 2023

github-actions bot commented Aug 28, 2023

openshift-ci-robot commented Aug 29, 2023

msherif1234 commented Aug 29, 2023

openshift-ci-robot commented Aug 29, 2023

msherif1234 commented Aug 29, 2023

msherif1234 commented Aug 29, 2023

github-actions bot commented Aug 29, 2023

msherif1234 commented Aug 29, 2023

msherif1234 commented Aug 29, 2023

github-actions bot commented Sep 2, 2023

openshift-ci-robot commented Sep 2, 2023

bn222 Sep 4, 2023

bn222 Sep 4, 2023 •

edited

Loading

msherif1234 Sep 4, 2023

bn222 commented Sep 4, 2023

msherif1234 commented Sep 4, 2023

github-actions bot commented Sep 4, 2023

jotak commented Sep 6, 2023

msherif1234 commented Sep 6, 2023

openshift-ci-robot commented Sep 6, 2023

openshift-ci-robot commented Sep 7, 2023 •

edited by openshift-ci bot

Loading

memodi commented Sep 7, 2023

memodi commented Sep 7, 2023

jotak commented Sep 8, 2023

openshift-ci bot commented Sep 8, 2023

NETOBSERV-1283: Make ifaces watcher netns aware #171

NETOBSERV-1283: Make ifaces watcher netns aware #171

Conversation

msherif1234 commented Aug 28, 2023 • edited Loading

codecov bot commented Aug 28, 2023 • edited Loading

Codecov Report

msherif1234 commented Aug 28, 2023

github-actions bot commented Aug 28, 2023

msherif1234 commented Aug 28, 2023

github-actions bot commented Aug 28, 2023

openshift-ci-robot commented Aug 29, 2023

msherif1234 commented Aug 29, 2023

openshift-ci-robot commented Aug 29, 2023

msherif1234 commented Aug 29, 2023

msherif1234 commented Aug 29, 2023

github-actions bot commented Aug 29, 2023

msherif1234 commented Aug 29, 2023

msherif1234 commented Aug 29, 2023

github-actions bot commented Sep 2, 2023

openshift-ci-robot commented Sep 2, 2023

bn222 Sep 4, 2023

Choose a reason for hiding this comment

bn222 Sep 4, 2023 • edited Loading

Choose a reason for hiding this comment

msherif1234 Sep 4, 2023

Choose a reason for hiding this comment

bn222 commented Sep 4, 2023

msherif1234 commented Sep 4, 2023

github-actions bot commented Sep 4, 2023

jotak commented Sep 6, 2023

msherif1234 commented Sep 6, 2023

openshift-ci-robot commented Sep 6, 2023

openshift-ci-robot commented Sep 7, 2023 • edited by openshift-ci bot Loading

memodi commented Sep 7, 2023

memodi commented Sep 7, 2023

jotak commented Sep 8, 2023

openshift-ci bot commented Sep 8, 2023

msherif1234 commented Aug 28, 2023 •

edited

Loading

codecov bot commented Aug 28, 2023 •

edited

Loading

bn222 Sep 4, 2023 •

edited

Loading

openshift-ci-robot commented Sep 7, 2023 •

edited by openshift-ci bot

Loading