-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1245: NETOBSERV-1304: fix TCP DNS query #206
Conversation
@msherif1234: This pull request references NETOBSERV-1245 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 31.71% 31.79% +0.08%
==========================================
Files 37 37
Lines 3371 3362 -9
==========================================
Hits 1069 1069
+ Misses 2239 2230 -9
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=8d87a3f make set-agent-image |
@msherif1234: This pull request references NETOBSERV-1245 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
792f3c3
to
1c0e985
Compare
@msherif1234: This pull request references NETOBSERV-1245 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=e860f81 make set-agent-image |
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
1c0e985
to
630c501
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=2b9f1d9 make set-agent-image |
@msherif1234: This pull request references NETOBSERV-1245 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's awesome ! thanks @msherif1234
Do you expect better performances since the DNS tracepoint is not used anymore ?
As followup, should we have a separated sampling
per feature (DNS / RTT) ? Or is there a way to avoid having sampling 1
to make it accurate.
cc'd @Amoghrd |
its not only for DNS/RTT even for the regular TC flows if sampling not 1 won't get very accurate latency as well, I spoke with @jotak and he told me for customers who are looking for accurate analysis its expected/encouraged to use sampling of |
/label qe-approved |
@msherif1234: This pull request references NETOBSERV-1245 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Tracking DNS over TCP was impossible using tracepoints as the dns hdr never exists in the 1st segment and when use ebpf TP there are no helpers to get to packet from the following segments
Solution was to do DNS tracking inline with TC hook and to gain better accuracy for all NDS queries its needed to run with sampling of 1
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.