Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use unknown for interface we can't detect instead of "" #250

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

msherif1234
Copy link
Contributor

Description

need to be consistent when can't find interface name and always use unknown string

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (6f1d70a) 33.86% compared to head (110b8ae) 34.06%.
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/exporter/proto.go 0.00% 16 Missing and 2 partials ⚠️
pkg/flow/deduper.go 85.00% 2 Missing and 1 partial ⚠️
pkg/utils/utils.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   33.86%   34.06%   +0.20%     
==========================================
  Files          39       39              
  Lines        3479     3508      +29     
==========================================
+ Hits         1178     1195      +17     
- Misses       2233     2243      +10     
- Partials       68       70       +2     
Flag Coverage Δ
unittests 34.06% <54.71%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotak
Copy link
Member

jotak commented Jan 22, 2024

/lgtm

@msherif1234
Copy link
Contributor Author

/approve

Copy link

openshift-ci bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 83765d0 into netobserv:main Jan 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants