Filter out sockets for loopback and unknown interfaces #260
Conversation
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
=======================================
Coverage 33.65% 33.65%
=======================================
Files 40 40
Lines 3542 3542
=======================================
Hits 1192 1192
Misses 2281 2281
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
msherif1234
changed the title
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=57ade44 make set-agent-image |
| @@ -17,7 +17,10 @@ static inline int trace_pkt_drop(void *ctx, u8 state, | |||
| u16 family = 0,flags = 0; | |||
|
|
|||
| id.if_index = skb->skb_iif; | |||
|
|
|||
| // filter out TCP sockets with unknown or loopback interface | |||
| if (id.if_index == 0 || id.if_index == 1) { | |||
There was a problem hiding this comment.
is it 100% sure that if_index 0 or 1 is always loopback or unknown ?
There was a problem hiding this comment.
yes those two index are reserved , I was hopping if there is api or helper but couldn't find any and saw other app doing the same check to detect lo
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
filter out noise flows when RTT and/or pkt drop is enabled for
lointerfacehere is a sample of those waste flows we can see when enable RTT or pkt drop
{ "AgentIP": "10.0.122.106", "Bytes": 32, "DnsErrno": 0, "Dscp": 0, "DstAddr": "127.0.0.1", "DstMac": "00:00:00:00:00:00", "DstPort": 80, "Duplicate": "false", "Etype": 2048, "Flags": 512, "FlowDirection": "0", "IfDirection": 0, "Interface": "lo", "K8S_FlowLayer": "infra", "Packets": 1, "Proto": 6, "SrcAddr": "127.0.0.1", "SrcMac": "00:00:00:00:00:00", "SrcPort": 60518, "TimeFlowEndMs": 1706717908848, "TimeFlowRttNs": 16000, "TimeFlowStartMs": 1706717908848, "TimeReceived": 1706717913, "app": "netobserv-flowcollector" } { "AgentIP": "10.0.31.177", "DnsErrno": 0, "Dscp": 0, "DstAddr": "::1", "DstMac": "00:00:00:00:00:00", "DstPort": 80, "Duplicate": "false", "Etype": 34525, "Flags": 2, "FlowDirection": "0", "IfDirection": 0, "Interface": "lo", "K8S_FlowLayer": "infra", "PktDropBytes": 40, "PktDropLatestDropCause": "SKB_DROP_REASON_NO_SOCKET", "PktDropLatestFlags": 2, "PktDropLatestState": "TCP_INVALID_STATE", "PktDropPackets": 1, "Proto": 6, "SrcAddr": "::1", "SrcMac": "00:00:00:00:00:00", "SrcPort": 37068, "TimeFlowEndMs": 1706722320508, "TimeFlowStartMs": 1706722320508, "TimeReceived": 1706722320, "app": "netobserv-flowcollector" }Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.