Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share errors counter across components #278

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Feb 26, 2024

  • All errors can now be found from metric "errors_total"
  • Use error name and exporter as labels

image

- All errors can now be found from metric "errors_total"
- Use error name and exporter as labels
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 36.08%. Comparing base (9507ebf) to head (be61272).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/exporter/kafka_proto.go 0.00% 2 Missing ⚠️
pkg/agent/agent.go 0.00% 1 Missing ⚠️
pkg/exporter/grpc_proto.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   35.90%   36.08%   +0.17%     
==========================================
  Files          42       42              
  Lines        3777     3786       +9     
==========================================
+ Hits         1356     1366      +10     
+ Misses       2343     2342       -1     
  Partials       78       78              
Flag Coverage Δ
unittests 36.08% <82.60%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msherif1234
Copy link
Contributor

/lgtm

@jotak
Copy link
Member Author

jotak commented Feb 26, 2024

/approve
thx

Copy link

openshift-ci bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b3c02b8 into netobserv:main Feb 26, 2024
8 checks passed
@jotak jotak deleted the errors-counter branch March 21, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants