-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add direct-flp mode documentation #285
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
=======================================
Coverage 36.08% 36.08%
=======================================
Files 42 42
Lines 3786 3786
=======================================
Hits 1366 1366
Misses 2342 2342
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
// Flowlogs-pipeline configuration, used when export is "direct-flp". Cf https://github.com/netobserv/flowlogs-pipeline | ||
// The "ingest" stage must be omitted from this configuration, since it is handled internally by the agent. | ||
// Flowlogs-pipeline configuration as YAML or JSON, used when export is "direct-flp". Cf https://github.com/netobserv/flowlogs-pipeline | ||
// The "ingest" stage must be omitted from this configuration, since it is handled internally by the agent. The first stage should follow "preset-ingester". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in flp direct mode what will happen if ingest stage not omitted will the pod crash or just ignored ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msherif1234 it may either crash or perhaps result in some undefined behaviour. Currently there is nothing like a "pipeline config validation" in FLP, perhaps this is something we could work on. But the rule of thumb today is that the provided pipeline has to be consistent. Note that, the pipeline config isn't like some independent config flags where we could omit any of them: here all the stages are inter-connected and if there's something wrong it's likely that the whole pipeline config can be screwed up. It's not new with direct-flp.
/lgtm |
thanks @msherif1234 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.