Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1514: drop go1.20 support #295

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Mar 12, 2024

No description provided.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.74%. Comparing base (2b91bd2) to head (fd4f1a2).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   36.26%   36.74%   +0.47%     
==========================================
  Files          42       42              
  Lines        3794     3813      +19     
==========================================
+ Hits         1376     1401      +25     
+ Misses       2340     2334       -6     
  Partials       78       78              
Flag Coverage Δ
unittests 36.74% <ø> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotak jotak changed the title drop go1.20 support NETOBSERV-1514: drop go1.20 support Mar 12, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 12, 2024

@jotak: This pull request references NETOBSERV-1514 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@msherif1234
Copy link
Contributor

@jotak
Copy link
Member Author

jotak commented Mar 12, 2024

pls update here too https://github.com/netobserv/netobserv-ebpf-agent/blob/main/scripts/generators.Dockerfile#L3

why? it's dropping support for 1.20 and starts testing on 1.22 but it doesn't change the current used version in builds which is 1.21

@msherif1234
Copy link
Contributor

pls update here too https://github.com/netobserv/netobserv-ebpf-agent/blob/main/scripts/generators.Dockerfile#L3

why? it's dropping support for 1.20 and starts testing on 1.22 but it doesn't change the current used version in builds which is 1.21

currently it uses 1.21.3 while u going to 1.21.7 so just to keep all in sync ?

@jotak
Copy link
Member Author

jotak commented Mar 12, 2024

hmm I see .. it's annoying to have this "toolchain 1.21.7" mention in go.mod, I would say any 1.21 version should be supported for the dev team we shouldn't have to stick to a particular z-stream on our local machines

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
@msherif1234
Copy link
Contributor

/lgtm
e2e errors seems to be baseline issue after recent FLP update #290

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 13, 2024

@jotak: This pull request references NETOBSERV-1514 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@msherif1234
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 58d01d9 into netobserv:main Mar 13, 2024
12 of 13 checks passed
@jotak jotak deleted the drop-1.20 branch March 21, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants