-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1514: drop go1.20 support #295
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
==========================================
+ Coverage 36.26% 36.74% +0.47%
==========================================
Files 42 42
Lines 3794 3813 +19
==========================================
+ Hits 1376 1401 +25
+ Misses 2340 2334 -6
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@jotak: This pull request references NETOBSERV-1514 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
why? it's dropping support for 1.20 and starts testing on 1.22 but it doesn't change the current used version in builds which is 1.21 |
currently it uses |
hmm I see .. it's annoying to have this "toolchain 1.21.7" mention in go.mod, I would say any 1.21 version should be supported for the dev team we shouldn't have to stick to a particular z-stream on our local machines |
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
/lgtm |
@jotak: This pull request references NETOBSERV-1514 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
58d01d9
into
netobserv:main
No description provided.