NETOBSERV-1595: generate BPF from CI #309
Conversation
|
Skipping CI for Draft Pull Request. |
jotak
added
the
ok-to-test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
=======================================
Coverage 33.84% 33.84%
=======================================
Files 47 47
Lines 3865 3865
=======================================
Hits 1308 1308
Misses 2469 2469
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=3ba1248 make set-agent-image |
|
@jotak: This pull request references NETOBSERV-1595 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jotak: This pull request references NETOBSERV-1595 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
I intentionally removed the .o files from source and generated a build just to make sure it uses CI-generated .o |
github-actions
bot
removed
the
ok-to-test
Dockerfile
Outdated
| FROM --platform=$BUILDPLATFORM docker.io/library/golang:1.21 as builder | ||
|
|
||
| # Build layer | ||
| FROM --platform=$TARGETPLATFORM fedora:38 as builder |
There was a problem hiding this comment.
Pls use fc39 as in the generator your pr should have no .o changes
Makefile
Outdated
| @echo "### Generating BPF Go bindings" | ||
| test -f $(shell go env GOPATH)/bin/bpf2go || go install github.com/cilium/ebpf/cmd/bpf2go@${CILIUM_EBPF_VERSION} |
There was a problem hiding this comment.
U can do preqs here instead of repeating install
|
/LGTM |
|
/test images |
1 similar comment
|
/test images |
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=9a271c2 make set-agent-image |
|
/approve @msherif1234 one downside of this is increased image build time, that can perhaps be painful when you build locally. If this ends up too painful we could create a separate dockerfile for local builds, that would diverge from CI dockerfile. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
make generatein 2 (one for BPF another for protoc ; we don't need to build protobuf from CI as this is still code)