Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov add env token from secret #317

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

jpinsonneau
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.45%. Comparing base (cb2cf53) to head (57b9274).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   33.63%   34.45%   +0.82%     
==========================================
  Files          47       48       +1     
  Lines        3865     3375     -490     
==========================================
- Hits         1300     1163     -137     
+ Misses       2477     2115     -362     
- Partials       88       97       +9     
Flag Coverage Δ
unittests 34.45% <ø> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

with:
files: ./cover.out
flags: unittests
fail_ci_if_error: true
fail_ci_if_error: true
verbose: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do u need to enable verbose all the time ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No but I'd like to enable it everywhere to avoid any surprises in the future

@msherif1234
Copy link
Contributor

/lgtm
/approve

Copy link

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 558d452 into netobserv:main Apr 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants