-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable IPFIX export #64
Conversation
Doing an initial view, it looks good! I'll do later a more detailed review. In the meantime, I think we should add e2e tests. For example, you can just copy the kafka folder into e.g. 1- in the 2- rename the kafka_test.go to ipfix_test.go, remove this lines and this lines. |
Thanks Mario, I will add the e2e tests. |
Adding hold labels for the feature freeze. |
@mariomac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. I have a suggestion about renaming a struct and a file, and a concern about the performance.
* IPFIX exporter and collector with tcp/udp * Enable ipfix export at the agent using config * Add vmware go-ipfix modules * Add the vendor directories * Add e2e tests for IPFIX * Caching of ie values for performance * Fix inconsistent vendor after merge * Fix lint error
This PR address the below issue https://github.com/netobserv/netobserv-ebpf-agent/issues/26 to provide IPFIX export of flow records, which can be consumed directly by any platform.