Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-868: Update to use cilium auto generated golang structures #90

Merged
merged 4 commits into from
Feb 15, 2023
Merged

NETOBSERV-868: Update to use cilium auto generated golang structures #90

merged 4 commits into from
Feb 15, 2023

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jan 24, 2023

generate golang structure from kernel tc plugin
and update the code to use the new data structures

Also updated cilium pkg to 0.10.0 and updated vendor pkg.

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@msherif1234 msherif1234 changed the title Update cilium WIP: Update to use cilium auto generated golang structures Jan 24, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #90 (30722c5) into main (c54e7eb) will increase coverage by 0.05%.
The diff coverage is 71.59%.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   41.54%   41.59%   +0.05%     
==========================================
  Files          29       29              
  Lines        1993     1993              
==========================================
+ Hits          828      829       +1     
+ Misses       1127     1126       -1     
  Partials       38       38              
Flag Coverage Δ
unittests 41.59% <71.59%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/agent.go 39.06% <ø> (ø)
pkg/ebpf/tracer.go 0.00% <0.00%> (ø)
pkg/exporter/ipfix.go 0.00% <0.00%> (ø)
pkg/flow/tracer_ringbuf.go 22.58% <0.00%> (ø)
pkg/flow/tracer_map.go 81.01% <75.00%> (ø)
pkg/flow/record.go 83.33% <91.66%> (ø)
pkg/exporter/proto.go 100.00% <100.00%> (ø)
pkg/flow/account.go 82.35% <100.00%> (ø)
pkg/flow/decorator.go 100.00% <100.00%> (ø)
pkg/flow/deduper.go 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@msherif1234 msherif1234 changed the title WIP: Update to use cilium auto generated golang structures Update to use cilium auto generated golang structures Jan 24, 2023
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@@ -6,7 +6,7 @@ The Network Observability eBPF Agent allows collecting and aggregating all the i
egress flows on a Linux host (required a Kernel 4.18+ with eBPF enabled).

* [How to compile](#how-to-compile)
* [Hot to configure](#how-to-configure)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@msherif1234 msherif1234 changed the title Update to use cilium auto generated golang structures NETOBSERV-868: Update to use cilium auto generated golang structures Feb 2, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 2, 2023

@msherif1234: This pull request references NETOBSERV-868 which is a valid jira issue.

In response to this:

generate golang structure from kernel tc plugin
and update the code to use the new data structures

Also updated cilium pkg to 0.10.0 and updated vendor pkg.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jotak
Copy link
Member

jotak commented Feb 7, 2023

/lgtm
thanks for this PR & the peer review!

@openshift-ci openshift-ci bot added the lgtm label Feb 7, 2023
@Amoghrd
Copy link

Amoghrd commented Feb 9, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 9, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

New image: ["quay.io/netobserv/netobserv-ebpf-agent:3079fa0"]. It will expire after two weeks.

@praveingk
Copy link
Collaborator

Hi @msherif1234 : Thanks for this major cleanup in the types. I tried it out and looks good to me 👍🏽

@msherif1234
Copy link
Contributor Author

Hi @msherif1234 : Thanks for this major cleanup in the types. I tried it out and looks good to me 👍🏽

Thanks @praveingk !!

@jotak
Copy link
Member

jotak commented Feb 10, 2023

/approve

@msherif1234
Copy link
Contributor Author

/approve cancel

@jotak jotak added no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval labels Feb 15, 2023
@jotak
Copy link
Member

jotak commented Feb 15, 2023

given the discussion we had today, I've added the no-qe label

/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak merged commit b98d705 into netobserv:main Feb 15, 2023
shach33 pushed a commit to praveingk/netobserv-ebpf-agent that referenced this pull request Apr 6, 2023
…etobserv#90)

* update vendor package and update cilium to 0.10.0

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

* update cilium version in the Makefile

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

* fix typo in the README.md

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

* replace custom go struct with cilium auto generated ones

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

---------

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
shach33 pushed a commit to praveingk/netobserv-ebpf-agent that referenced this pull request Apr 6, 2023
…etobserv#90)

* update vendor package and update cilium to 0.10.0

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

* update cilium version in the Makefile

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

* fix typo in the README.md

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

* replace custom go struct with cilium auto generated ones

Signed-off-by: msherif1234 <mmahmoud@redhat.com>

---------

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants