-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-868: Update to use cilium auto generated golang structures #90
Conversation
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 41.54% 41.59% +0.05%
==========================================
Files 29 29
Lines 1993 1993
==========================================
+ Hits 828 829 +1
+ Misses 1127 1126 -1
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@@ -6,7 +6,7 @@ The Network Observability eBPF Agent allows collecting and aggregating all the i | |||
egress flows on a Linux host (required a Kernel 4.18+ with eBPF enabled). | |||
|
|||
* [How to compile](#how-to-compile) | |||
* [Hot to configure](#how-to-configure) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥 🔥
@msherif1234: This pull request references NETOBSERV-868 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/ok-to-test |
New image: ["quay.io/netobserv/netobserv-ebpf-agent:3079fa0"]. It will expire after two weeks. |
Hi @msherif1234 : Thanks for this major cleanup in the types. I tried it out and looks good to me 👍🏽 |
Thanks @praveingk !! |
/approve |
/approve cancel |
given the discussion we had today, I've added the no-qe label /approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…etobserv#90) * update vendor package and update cilium to 0.10.0 Signed-off-by: msherif1234 <mmahmoud@redhat.com> * update cilium version in the Makefile Signed-off-by: msherif1234 <mmahmoud@redhat.com> * fix typo in the README.md Signed-off-by: msherif1234 <mmahmoud@redhat.com> * replace custom go struct with cilium auto generated ones Signed-off-by: msherif1234 <mmahmoud@redhat.com> --------- Signed-off-by: msherif1234 <mmahmoud@redhat.com>
…etobserv#90) * update vendor package and update cilium to 0.10.0 Signed-off-by: msherif1234 <mmahmoud@redhat.com> * update cilium version in the Makefile Signed-off-by: msherif1234 <mmahmoud@redhat.com> * fix typo in the README.md Signed-off-by: msherif1234 <mmahmoud@redhat.com> * replace custom go struct with cilium auto generated ones Signed-off-by: msherif1234 <mmahmoud@redhat.com> --------- Signed-off-by: msherif1234 <mmahmoud@redhat.com>
generate golang structure from kernel tc plugin
and update the code to use the new data structures
Also updated cilium pkg to 0.10.0 and updated vendor pkg.