Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add owners file #95

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Add owners file #95

merged 1 commit into from
Feb 16, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Feb 10, 2023

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak added no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval labels Feb 10, 2023
@msherif1234
Copy link
Contributor

Hi @jotak, I don't think u need the entire team to be in the approval/reviewer list for the agent repo, maybe u and stlee for now ?

@jotak
Copy link
Member Author

jotak commented Feb 15, 2023

At some point we should add a GOVERNANCE.md file to each project to clarify maintainership, emeritus contributors, etc. For the time being I'm just reproducing in prow what we have in our github maintainers team.

@jotak
Copy link
Member Author

jotak commented Feb 15, 2023

Example of a governance file: https://github.com/jaegertracing/jaeger/blob/main/GOVERNANCE.md

@openshift-ci openshift-ci bot added the lgtm label Feb 15, 2023
@jotak jotak merged commit 6a074bd into netobserv:main Feb 16, 2023
shach33 pushed a commit to praveingk/netobserv-ebpf-agent that referenced this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants