Bump ubi 9.4 #41
Bump ubi 9.4 #41
Conversation
Dockerfile
Outdated
| @@ -26,10 +26,10 @@ RUN GOARCH=$TARGETARCH make compile | |||
| RUN mkdir -p output | |||
|
|
|||
| # Create final image from ubi + built binary | |||
| FROM --platform=$TARGETPLATFORM registry.access.redhat.com/ubi9/ubi:9.3 | |||
| FROM --platform=$TARGETPLATFORM registry.access.redhat.com/ubi9/ubi:9.4 | |||
There was a problem hiding this comment.
guys, is there a reason here to use the "full" ubi and not the minimal like we do elsewhere ? Is it that we need more tooling in the image?
There was a problem hiding this comment.
I just tried building running e2e using ubi-minimal:9.4 it shows no issue I don't think we need the full image here you switched in this PR
There was a problem hiding this comment.
ok, commit added to use minimal
cc @jpinsonneau (in case not using minimal was intentional)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage 26.08% 26.08%
=======================================
Files 8 8
Lines 1081 1081
=======================================
Hits 282 282
Misses 778 778
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/retest |
|
@jpinsonneau , looking at the error, it seems like in the e2e test "TestFlowCapture", the output/flow directory does not exist for some reason, when using a minimal base image. Any idea why? konflux bot is also upgrading the ubi to 9.4: #70 - so if we think this is good enough and we don't need the minimal image, I can close this PR. But I'd be curious to understand what makes it fail with minimal |
UBI 9.3 contains As discussed in this slack thread, you need to have Did you try the |
|
let's see if adding tar fixes it then (I prefer to stick with the current behaviour as much as possible, and adding tar was something we do downstream also) |
|
/retest |
|
@jpinsonneau e2e pass now \o/ |
|
@jpinsonneau I think this change will be necessary for the prow/image test to pass |
|
/test images |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.