NETOBSERV-1703 Add enrichment in packet capture

[jpinsonneau]

Description

CLI pcap showing table while running packet capture:

• as same as flow you can live filter on these
• and see enrichement

Output file is a pcapng including Src / Dst enriched fields (currently using frame -> Interface section)
Other fields are not kept here since the packet is supposed to contains everything but we can add extras if needed

Dependencies

netobserv/netobserv-ebpf-agent#364

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Attention: Patch coverage is 19.23077% with 63 lines in your changes missing coverage. Please review.

Project coverage is 26.08%. Comparing base (8f2dce7) to head (0748191).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   28.53%   26.08%   -2.45%     
==========================================
  Files           8        8              
  Lines        1076     1081       +5     
==========================================
- Hits          307      282      -25     
- Misses        747      778      +31     
+ Partials       22       21       -1     

Flag	Coverage Δ
unittests	26.08% <19.23%> (-2.45%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
cmd/root.go	60.60% <ø> (ø)
cmd/flow_capture.go	32.78% <60.00%> (+0.22%)	⬆️
cmd/map_format.go	22.96% <69.23%> (+1.06%)	⬆️
cmd/packet_capture.go	0.00% <0.00%> (-29.83%)	⬇️

[jpinsonneau]

e2e will pass as soon as eBPF PR is merged

[jpinsonneau]

Rebased to include latests options.

You can give a try with ebpf image using:

NETOBSERV_AGENT_IMAGE=quay.io/netobserv/netobserv-ebpf-agent:30c0f75 ./build/oc-netobserv packets

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:23784f6

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=23784f6 make commands

or download the updated commands.

[jpinsonneau]

Rebased without changes

[Amoghrd]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:cf95f76

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=cf95f76 make commands

or download the updated commands.

[Amoghrd]

/label qe-approved

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jpinsonneau]

CI tests are now passing ❤️