Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-1757: Add tcp_flags flow filter option and update the doc #66

Merged
merged 1 commit into from
Aug 6, 2024
Merged

NETOBSERV-1757: Add tcp_flags flow filter option and update the doc #66

merged 1 commit into from
Aug 6, 2024

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jul 11, 2024 •
edited

Description

add tcp flags flow filter support

Dependencies

netobserv/netobserv-ebpf-agent#367

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@msherif1234
Copy link
Contributor Author

/ok-to-test

@github-actions GitHub Actions
Copy link

New image:
quay.io/netobserv/network-observability-cli:8a72143

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=8a72143 make commands

or download the updated commands.

@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.53%. Comparing base (50a0722) to head (9d6b80e).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   28.53%   28.53%           
=======================================
  Files           8        8           
  Lines        1076     1076           
=======================================
  Hits          307      307           
  Misses        747      747           
  Partials       22       22
Flag Coverage Δ
unittests 28.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@msherif1234 msherif1234 changed the title Add tcp_flags flow filter option and update the doc NETOBSERV-1757: Add tcp_flags flow filter option and update the doc Jul 11, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 11, 2024 •
edited by openshift-ci bot

@msherif1234: This pull request references NETOBSERV-1757 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Description

add tcp flags flow filter support

Dependencies

netobserv/netobserv-ebpf-agent#367

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jpinsonneau
jpinsonneau reviewed Jul 12, 2024
View reviewed changes
docs/netobserv_cli_flows_config.md Outdated
Comment on lines 28 to 30
| --log-level | Components logs | for example debug or trace | info |
| --max-time | Maximum capture time | for example 10m or 30s | 5m |
| --max-bytes | max-bytes: maximum capture bytes | for example 10000000 (1MB) | 50000000 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging #65 so you don't have to manage this here ;)

jpinsonneau
jpinsonneau reviewed Jul 12, 2024
View reviewed changes
docs/netobserv_cli_packets_config.md Outdated
Comment on lines 20 to 28
- The following table shows all supported features options.

| Option | Description | Possible values | Default |
|------------------|----------------------------------|----------------------------|----------|
| --log-level | Components logs | for example debug or trace | info |
| --max-time | Maximum capture time | for example 10m or 30s | 5m |
| --max-bytes | max-bytes: maximum capture bytes | for example 10000000 (1MB) | 50000000 |


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

jpinsonneau
jpinsonneau approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just remove the non related docs

@openshift-ci openshift-ci bot added the lgtm label Jul 12, 2024
@msherif1234
Add tcp_flags flow filter option and update the doc
9d6b80e 
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Jul 12, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@github-actions GitHub Actions
Copy link

New image:
quay.io/netobserv/network-observability-cli:4452428

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=4452428 make commands

or download the updated commands.

@openshift-ci openshift-ci bot added the lgtm label Jul 19, 2024
@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f0236ac into netobserv:main Aug 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpinsonneau jpinsonneau jpinsonneau approved these changes

Assignees

@jpinsonneau jpinsonneau

Labels
approved jira/valid-reference lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@msherif1234 @openshift-ci-robot @jpinsonneau