-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1757: Add tcp_flags flow filter option and update the doc #66
Conversation
/ok-to-test |
New image: It will expire after two weeks. To use this build, update your commands using: USER=netobserv VERSION=8a72143 make commands |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=======================================
Coverage 28.53% 28.53%
=======================================
Files 8 8
Lines 1076 1076
=======================================
Hits 307 307
Misses 747 747
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. |
@msherif1234: This pull request references NETOBSERV-1757 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
docs/netobserv_cli_flows_config.md
Outdated
| --log-level | Components logs | for example debug or trace | info | | ||
| --max-time | Maximum capture time | for example 10m or 30s | 5m | | ||
| --max-bytes | max-bytes: maximum capture bytes | for example 10000000 (1MB) | 50000000 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm merging #65 so you don't have to manage this here ;)
docs/netobserv_cli_packets_config.md
Outdated
- The following table shows all supported features options. | ||
|
||
| Option | Description | Possible values | Default | | ||
|------------------|----------------------------------|----------------------------|----------| | ||
| --log-level | Components logs | for example debug or trace | info | | ||
| --max-time | Maximum capture time | for example 10m or 30s | 5m | | ||
| --max-bytes | max-bytes: maximum capture bytes | for example 10000000 (1MB) | 50000000 | | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just remove the non related docs
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
/ok-to-test |
New image: It will expire after two weeks. To use this build, update your commands using: USER=netobserv VERSION=4452428 make commands |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
add tcp flags flow filter support
Dependencies
netobserv/netobserv-ebpf-agent#367
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.