Skip to content

Commit

Permalink
fix table columns not showing
Browse files Browse the repository at this point in the history
  • Loading branch information
jpinsonneau committed Jul 2, 2024
1 parent 530dcf4 commit 310ab45
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
7 changes: 2 additions & 5 deletions web/src/components/drawer/drawer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export interface NetflowTrafficDrawerProps {
flows: Record[];
selectedRecord?: Record;
availableColumns: Column[];
selectedColumns: Column[];
setColumns: (v: Column[]) => void;
columnSizes: ColumnSizeMap;
setColumnSizes: (v: ColumnSizeMap) => void;
Expand Down Expand Up @@ -93,10 +94,6 @@ export interface NetflowTrafficDrawerProps {
}

export const NetflowTrafficDrawer: React.FC<NetflowTrafficDrawerProps> = props => {
const getSelectedColumns = React.useCallback(() => {
return props.availableColumns.filter(column => column.isSelected);
}, [props.availableColumns]);

const onRecordSelect = React.useCallback(
(record?: Record) => {
props.clearSelections();
Expand Down Expand Up @@ -251,7 +248,7 @@ export const NetflowTrafficDrawer: React.FC<NetflowTrafficDrawerProps> = props =
selectedRecord={props.selectedRecord}
size={props.size}
onSelect={onRecordSelect}
columns={getSelectedColumns()}
columns={props.selectedColumns}
setColumns={(v: Column[]) =>
props.setColumns(v.concat(props.availableColumns.filter(col => !col.isSelected)))
}
Expand Down
5 changes: 5 additions & 0 deletions web/src/components/netflow-traffic.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,10 @@ export const NetflowTraffic: React.FC<NetflowTrafficProps> = ({ forcedFilters, i
[model.columns, model.config.features, isConnectionTracking]
);

const getSelectedColumns = React.useCallback(() => {
return getAvailableColumns().filter(column => column.isSelected);
}, [getAvailableColumns]);

const updateTopologyMetricType = React.useCallback(
(metricType: MetricType) => {
if (isTimeMetric(metricType)) {
Expand Down Expand Up @@ -1241,6 +1245,7 @@ export const NetflowTraffic: React.FC<NetflowTrafficProps> = ({ forcedFilters, i
clearSelections={clearSelections}
availableColumns={getAvailableColumns(true)}
maxChunkAge={model.config.maxChunkAgeMs}
selectedColumns={getSelectedColumns()}
/>
}
{initState.current.includes('initDone') && (
Expand Down

0 comments on commit 310ab45

Please sign in to comment.