-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-316 Console plugin as standalone #163
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I just had to run install-frontend before start-standalone to make it work.
Thanks!
Yes I can add this on both |
/lgtm |
@jpinsonneau just ran that on my machine ... looks good to me. some remarks:: (1) the term (2) For completeness, it might be nice to have some mock Loki (or simulation) of data so that when you run the plug-in without real data we will be able to show something. (3) From looking on the screenshot - need to add the nice icons back :-) |
This actually come from
Or remove these and run
I'm on it 👍 currently we have the json-server but the jsons are outdated. I'm also looking if we can have something better like reusing mocks from tests or restore a loki storage from previous saved data.
This will be done after #152 merge Thanks for the feedback @eranra ! |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Rebased to test with |
This allow to run plugin as standalone. You can
port-forward
loki from anywhere or mock it.Simply run
make start-standalone
to run backend + standalone frontend with live reloadingOr
build-standalone
thenmake serve
.Generated
index.html
+ js files are hosted in backend at http://localhost:9001/You can run cypress testing using this method. Simply update port number in consts.js
Will need #152 to support dark theme & implements
ResourceLink
icons. This can be added in another PR.