NETOBSERV-602 Fix query stats computed for topology #226
Conversation
|
@memodi stats between flow table and topology are much more consistent:
|
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: ["quay.io/netobserv/network-observability-console-plugin:4adc912"]. It will expire after two weeks. |
jotak
force-pushed
the
fix-stats-panel-metrics
branch
from
67d7a04
to
8b84d4f
Compare
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: ["quay.io/netobserv/network-observability-console-plugin:894d882"]. It will expire after two weeks. |
|
/retest |
| "Filtered sum of top-k bytes / filtered total bytes": "Filtered sum of top-k bytes / filtered total bytes", | ||
| "Filtered top-k byte rate / filtered total byte rate": "Filtered top-k byte rate / filtered total byte rate", | ||
| "Filtered byte rate": "Filtered byte rate", | ||
| "Filtered sum of top-k packets / filtered total packets": "Filtered sum of top-k packets / filtered total packets", |
There was a problem hiding this comment.
Should we keep "Filtered" mention when we don't have filters ?
There was a problem hiding this comment.
We could have something more detailed per context, e.g.:
- For flow queries: "Filtered sum of bytes" => "Sum of bytes from resulting flows"
- For topology queries: "Filtered sum of bytes" => "Sum of bytes from resulting graph"
- For overview queries: "Filtered sum of top-k bytes / filtered total bytes" => "Sum of bytes from resulting top-k metrics / from resulting total"
I don't know, it doesn't sound perfect either, I'm glad if someone comes up with a better proposal
jotak
force-pushed
the
fix-stats-panel-metrics
branch
from
9d249b1
to
2050346
Compare
|
New changes are detected. LGTM label has been removed. |
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: ["quay.io/netobserv/network-observability-console-plugin:6d872f1"]. It will expire after two weeks. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The biggest issue was stats being picked up only for the first metric, which obviously could not produce correct global statistics On top of that, I did the following changes: - Use the already computed rates instead of computing it again (in a different way) - Decouple FlowsQuerySummary vs MetricsQuerySummary (separation of concerns; the two resulting components end up being quite different) - For overview, add more info in stats tooltip to help user understand what the 2 compared values are. fix merge issues i18n gen
jotak
force-pushed
the
fix-stats-panel-metrics
branch
from
2050346
to
ee6c8b6
Compare
github-actions
bot
removed
the
ok-to-test
|
merging (@jpinsonneau previously approve, it was just rebased) |
https://issues.redhat.com/browse/NETOBSERV-602 (follow-up)
The biggest issue was stats being picked up only for the first metric, which obviously could not produce correct global statistics
On top of that, I did the following changes: