Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-779 topology view crashes when layout display changed to Grid #284

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Feb 7, 2023

Updated cypress and PF dependencies (including patternfly/patternfly-react#8761)
Fixed cypress tests
Moved to typescript

image

@jpinsonneau
Copy link
Contributor Author

@Amoghrd
Copy link
Contributor

Amoghrd commented Feb 27, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 27, 2023
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-console-plugin:c45ab9c"]. It will expire after two weeks.

@jpinsonneau
Copy link
Contributor Author

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 3, 2023
@jpinsonneau jpinsonneau marked this pull request as ready for review March 3, 2023 09:58
@Amoghrd
Copy link
Contributor

Amoghrd commented Mar 3, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 3, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

New image: ["quay.io/netobserv/network-observability-console-plugin:954499e"]. It will expire after two weeks.

@Amoghrd
Copy link
Contributor

Amoghrd commented Mar 3, 2023

@jpinsonneau Still seeing crashes when changing groups are changed when animation is still running. Changing the layout when the animation is running does not seems to lead to crashes

@memodi
Copy link
Contributor

memodi commented Mar 7, 2023

@jpinsonneau Still seeing crashes when changing groups are changed when animation is still running. Changing the layout when the animation is running does not seems to lead to crashes

@Amoghrd - could you share screen recordings if this is being reproduced conistently? I just ran entire topology test suite it runs successfully with no crashes (ran multiple times). The tests itself require some modifications for routes URL, I'll create a PR for it.

@Amoghrd
Copy link
Contributor

Amoghrd commented Mar 13, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Mar 13, 2023
@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ac487e1 into netobserv:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants