Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to go1.19 #292

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Move to go1.19 #292

merged 3 commits into from
Feb 15, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Feb 13, 2023

No description provided.

OlivierCazade
OlivierCazade reviewed Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also move the go version in the go.mod file.

@jotak
Copy link
Member Author

jotak commented Feb 14, 2023

@OlivierCazade would that work for you? We still allow 1.18 to not be too strict with users, and add it to the test matrix?
It just add a little bit of maintenance overhead if we use branch protection with required checks, at some point.

@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Feb 14, 2023
OlivierCazade
OlivierCazade approved these changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@openshift-ci openshift-ci bot added the lgtm label Feb 15, 2023
@jotak
Copy link
Member Author

jotak commented Feb 15, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 590bfb4 into netobserv:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierCazade OlivierCazade OlivierCazade approved these changes

@jpinsonneau jpinsonneau Awaiting requested review from jpinsonneau

Assignees

@OlivierCazade OlivierCazade

Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jotak @OlivierCazade @openshift-merge-robot