Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-906 Document json format #296

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Feb 27, 2023

Hey @jpinsonneau @OlivierCazade @skrthomas ,

This PR is a first step to automate generating doc for our custom the json format, which now become mandatory to have since it is exposed for kafka export (and it is anyway good to have for people willing to query Loki directly).

I didn't find a satisfying Typescript-API-doc-to-asciidoc tool so what I plan to do is doing this in two steps:

  • First, as shown in this PR, generate Typescipt-API-to-markdown here, without much post-edition of the generated files
  • Next, open a PR on the operator side that pulls markdown from there, do some post-edition (e.g. merge all in a single file, do some sed here and there), and convert to asciidoc. This will allow having our asciidoc consumable for downstream all in one place.

@skrthomas
Copy link
Contributor

/lgtm

Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jotak
Copy link
Member Author

jotak commented Mar 1, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 1, 2023
@openshift-merge-robot openshift-merge-robot merged commit 4a46eb6 into netobserv:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants