Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-849 Console plugin multi-arch builds (upstream) #298

Merged
merged 1 commit into from
May 11, 2023

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Mar 2, 2023

Implements multi arch builds and add documentation and consistency

$ make help

Usage:
  make <target>

General
  help                  Display this help.
  prereqs               Test if prerequisites are met, and installing missing dependencies
  vendors               Check go vendors

Develop
  start                 Run backend and frontend
  start-standalone      Run backend and frontend as standalone
  start-standalone-mock  Run backend using mocks and frontend as standalone
  bridge                Bridge OCP console
  generate-doc          Generate documentation of the flows JSON format

Develop frontend
  install-frontend      Run frontend npm install
  fmt-frontend          Run frontend i18n and fmt
  lint-frontend         Lint frontend code
  test-frontend         Test frontend using jest
  build-backend         Build backend

Develop backend
  fmt-backend           Run backend go fmt
  lint-backend          Lint backend code
  test-backend          Test backend using go test
  cypress               Test frontend using cypress
  just-build-frontend   Build frontend
  build-frontend-standalone  Run npm install, format and build frontend as standalone
  serve                 Run backend
  serve-mock            Run backend using mocks

Images
  image-build           Build MULTIARCH_TARGETS images
  image-push            Push MULTIARCH_TARGETS images
  manifest-build        Build MULTIARCH_TARGETS manifest
  manifest-push         Push MULTIARCH_TARGETS manifest
  ci-images-build       Build CI images
  ci-images-push        Push CI images

shortcuts helpers
  fmt                   Fmt all
  lint                  Lint all
  test                  Test all
  i18n                  Run frontend i18n
  build-frontend        Run npm install, format and build frontend
  build                 Build all
  build-standalone      Build all as standalone
  frontend              Build lint and test frontend
  backend               Build lint and test backend
  build-image           Build MULTIARCH_TARGETS images
  push-image            Push MULTIARCH_TARGETS images
  build-manifest        Build MULTIARCH_TARGETS manifest
  push-manifest         Push MULTIARCH_TARGETS manifest
  images                Build and push MULTIARCH_TARGETS images and related manifest
  build-ci-images       Build CI images
  push-ci-images        Push CI images
  ci-images             Build and push CI images

image

Thanks @OlivierCazade for the help !

Please use netobserv/flowlogs-pipeline#426 for main discussion and this PR only for specific items

Makefile Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #298 (51fa01d) into main (d1d36c2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   58.31%   58.31%           
=======================================
  Files         148      148           
  Lines        6592     6592           
  Branches      792      792           
=======================================
  Hits         3844     3844           
  Misses       2531     2531           
  Partials      217      217           
Flag Coverage Δ
uitests 58.97% <ø> (ø)
unittests 56.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-console-plugin:6179197"]. It will expire after two weeks.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 25, 2023
Copy link
Collaborator

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d99e5a4 into netobserv:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants