NETOBSERV-922 - Flaky topology data #301
Conversation
Codecov Report
@@ Coverage Diff @@
## main #301 +/- ##
==========================================
- Coverage 58.41% 58.35% -0.06%
==========================================
Files 148 148
Lines 6581 6587 +6
Branches 786 792 +6
==========================================
Hits 3844 3844
- Misses 2520 2526 +6
Partials 217 217
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| const parent = data.nodeType !== 'unknown' ? addPossibleGroups(data.peer) : undefined; | ||
| let node = nodes.find(n => n.type === 'node' && n.id === data.peer.id); |
There was a problem hiding this comment.
The root cause of this issue is that unknown nammed items were generating nodes with the same peer id as groups.
To avoid such issues 'unknown' nodes can't have parents + nodes find function will return only node types
| parent.children!.push(node.id); | ||
| if (parent) { | ||
| if (parent.id == node.id) { | ||
| console.error('addNode parent === node', parent, node); |
There was a problem hiding this comment.
Also console will throw error in case of similar issue
|
/lgtm |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: ["quay.io/netobserv/network-observability-console-plugin:2faf5f7"]. It will expire after two weeks. |
|
@jpinsonneau All the cola layouts and force layouts look weird. This occurred after I refreshed after encountering the below error(was clicking a lot of things and ended up on this error, dont know the exact scope and group)
|
I can't reproduce this on
I'm also having this while playing with groups. Switching "Collapse groups" option usually fix that. We can create a followup for that as it's not related to parent / children crash. |
|
/label qe-approved |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
unknownnodes while grouping