Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-916 Higher CPU utilization seen due to connection tracking #303

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Mar 15, 2023

Manage case when flow outputRecordTypes is disabled

image

image

image

@jpinsonneau jpinsonneau requested a review from jotak March 15, 2023 10:50
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #303 (039811f) into main (61a4f9b) will decrease coverage by 0.02%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   58.81%   58.79%   -0.02%     
==========================================
  Files         147      147              
  Lines        6458     6466       +8     
  Branches      769      772       +3     
==========================================
+ Hits         3798     3802       +4     
- Misses       2447     2449       +2     
- Partials      213      215       +2     
Flag Coverage Δ
uitests 59.48% <44.44%> (-0.02%) ⬇️
unittests 56.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/components/dropdowns/query-options-dropdown.tsx 84.84% <0.00%> (ø)
web/src/components/netflow-traffic.tsx 54.16% <50.00%> (-0.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Amoghrd
Copy link
Contributor

Amoghrd commented Mar 16, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 16, 2023
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-console-plugin:8fa7a4b"]. It will expire after two weeks.

@Amoghrd
Copy link
Contributor

Amoghrd commented Mar 17, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Mar 17, 2023
@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e0adb59 into netobserv:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants