Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit CSS updates #306

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Mar 20, 2023

  • border under table headers
  • broken lines on right
  • increased a bit histogram height
  • histogram title (suggestion)

image

Comment on lines +244 to +246
<FlexItem flex={{ default: 'flex_1' }}>
<Text>{t('Number of logs over time')}</Text>
</FlexItem>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a value adding this title on top left corner of the histogram for you guys ?
It would replace a tooltip while hovering the graph

@jpinsonneau jpinsonneau added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #306 (60d9c42) into main (e0adb59) will increase coverage by 0.26%.
The diff coverage is 22.91%.

@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   58.79%   59.06%   +0.26%     
==========================================
  Files         147      120      -27     
  Lines        6466     4849    -1617     
  Branches      772      783      +11     
==========================================
- Hits         3802     2864     -938     
+ Misses       2449     1856     -593     
+ Partials      215      129      -86     
Flag Coverage Δ
uitests 59.06% <22.91%> (-0.43%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/netflow-table/netflow-table-header.tsx 34.04% <ø> (ø)
web/src/components/netflow-traffic.tsx 53.93% <0.00%> (-0.24%) ⬇️
web/src/components/metrics/histogram.tsx 16.51% <11.11%> (-0.97%) ⬇️
web/src/utils/highlight-hook.ts 15.21% <15.21%> (ø)
web/src/components/guided-tour/guided-tour.tsx 57.37% <59.09%> (+6.26%) ⬆️

... and 29 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ca87bd1 into netobserv:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants