Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-935 Disable notch to switch between FLOWS and CONNECTIONS when logType != ALL #307

Merged
merged 1 commit into from
Mar 23, 2023
Merged

NETOBSERV-935 Disable notch to switch between FLOWS and CONNECTIONS when logType != ALL #307

merged 1 commit into from
Mar 23, 2023

Conversation

jpinsonneau
Copy link
Contributor

  • remove switch button in side panel on Event / Type when both Flow and Conversation are not available
  • fix recordType not saved in URL

@codecov
Copy link

codecov bot commented Mar 21, 2023 •
edited

Codecov Report

Merging #307 (d152658) into main (e0adb59) will decrease coverage by 1.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
- Coverage   58.79%   56.84%   -1.96%     
==========================================
  Files         147       28     -119     
  Lines        6466     1687    -4779     
  Branches      772        0     -772     
==========================================
- Hits         3802      959    -2843     
+ Misses       2449      641    -1808     
+ Partials      215       87     -128
Flag Coverage Δ
uitests ?
unittests 56.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 119 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Amoghrd
Copy link
Contributor

Amoghrd commented Mar 21, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 21, 2023
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-console-plugin:cf96752"]. It will expire after two weeks.

@Amoghrd
Copy link
Contributor

Amoghrd commented Mar 21, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Mar 21, 2023
OlivierCazade
OlivierCazade approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@openshift-ci openshift-ci bot added the lgtm label Mar 23, 2023
@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 01cb746 into netobserv:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierCazade OlivierCazade OlivierCazade approved these changes

@Amoghrd Amoghrd Awaiting requested review from Amoghrd

Assignees

@OlivierCazade OlivierCazade

Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpinsonneau @Amoghrd @OlivierCazade @openshift-merge-robot