Check i18n on PR check #308
Conversation
jotak
added
no-qe
Codecov Report
@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 58.79% 58.79%
=======================================
Files 147 147
Lines 6466 6466
Branches 772 772
=======================================
Hits 3802 3802
Misses 2449 2449
Partials 215 215
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
.github/workflows/pull_request.yml
Outdated
| @@ -43,7 +43,7 @@ jobs: | |||
| - name: checkout | |||
| uses: actions/checkout@v3 | |||
| - name: build and test | |||
| run: make frontend && git diff --exit-code | |||
| run: make frontend i18n && git diff --exit-code | |||
There was a problem hiding this comment.
As build-frontend already run fmt-frontend in the Makefile, I would prefer forcing i18n in this command so developers don't need to think about it before pushing code.
WDYT ?
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.