Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tab trailing semicolon #319

Merged

Conversation

jpinsonneau
Copy link
Contributor

@andrew-ronaldson found a trailing semicolon in tab view (thanks for that !!)
image

This PR removes it and fix tab height

@jpinsonneau jpinsonneau added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #319 (e5ad1df) into main (644410a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #319   +/-   ##
=======================================
  Coverage   58.41%   58.41%           
=======================================
  Files         148      148           
  Lines        6581     6581           
  Branches      786      786           
=======================================
  Hits         3844     3844           
  Misses       2520     2520           
  Partials      217      217           
Flag Coverage Δ
uitests 59.04% <ø> (ø)
unittests 56.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/netflow-tab.tsx 50.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jotak
Copy link
Member

jotak commented Apr 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 3, 2023
@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 4, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5155dc3 into netobserv:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants