Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update connection tracking tooltip after change in CRD #323

Merged

Conversation

OlivierCazade
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #323 (4e6607c) into main (d1d36c2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage   58.31%   58.31%           
=======================================
  Files         148      148           
  Lines        6592     6592           
  Branches      792      792           
=======================================
  Hits         3844     3844           
  Misses       2531     2531           
  Partials      217      217           
Flag Coverage Δ
uitests 58.97% <ø> (ø)
unittests 56.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/components/dropdowns/query-options-dropdown.tsx 84.84% <ø> (ø)

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OlivierCazade ! I missed that one 😿

@OlivierCazade
Copy link
Collaborator Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OlivierCazade

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2a47af3 into netobserv:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants