Add standalone image creation #325
Conversation
Codecov Report
@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 57.83% 58.77% +0.94%
==========================================
Files 150 121 -29
Lines 6652 4907 -1745
Branches 795 795
==========================================
- Hits 3847 2884 -963
+ Misses 2588 1894 -694
+ Partials 217 129 -88
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
What's the purpose / how does it differ from the usual image? |
|
@jotak This image creates a standalone console based on the |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: quay.io/netobserv/network-observability-console-plugin:6a0ea11. It will expire after two weeks. |
jpinsonneau
force-pushed
the
add_standalone
branch
from
cc8a2de
to
985b909
Compare
github-actions
bot
removed
the
ok-to-test
|
Rebased + reused same docker file passing |
| # Standalone `true` is used to build frontend outside of OCP Console environment | ||
| STANDALONE ?= false | ||
| BUILDSCRIPT = | ||
|
|
||
| ifeq (${STANDALONE}, true) | ||
| BUILDSCRIPT := :standalone | ||
| IMAGE_TAG_BASE := quay.io/${IMAGE_ORG}/network-observability-standalone-frontend | ||
| endif |
There was a problem hiding this comment.
@jotak @OlivierCazade are you fine with that approach ?
I don't want to maintain 2 separate docker files so I feel it would be better.
There was a problem hiding this comment.
sounds good to me
btw, I guess it deserves some instruction in the README (?)
jpinsonneau
changed the title
jpinsonneau
changed the title
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build frontend image as standalone using:
Solve #200