NETOBSERV-387 UI: filter "NOT"

[jpinsonneau]

This PR implement equal / not equal dropdown between filter key and value:

Clicking directly in the compare symbol switch from one to another

Once the proper comparaison is selected, you can type your filter as usual and see the result:

Solve #328

[codecov]

Codecov Report

Merging #333 (98dd766) into main (99b3a5f) will decrease coverage by 2.69%.
The diff coverage is 51.51%.

@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
- Coverage   58.08%   55.39%   -2.69%     
==========================================
  Files         149       29     -120     
  Lines        6615     1753    -4862     
  Branches      792        0     -792     
==========================================
- Hits         3842      971    -2871     
+ Misses       2556      694    -1862     
+ Partials      217       88     -129     

Flag	Coverage Δ
uitests	?
unittests	55.39% <51.51%> (-0.18%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/plugin-backend.go	0.00% <0.00%> (ø)
pkg/kubernetes/client/client.go	0.00% <0.00%> (ø)
pkg/kubernetes/auth/check_auth.go	85.24% <100.00%> (-0.24%)	⬇️

... and 123 files with indirect coverage changes

[jpinsonneau]

@eranra @kfirtoledo

[kfirtoledo]

Looks good

[eranra]

@jpinsonneau, this looks very good. Thanks for getting this done so quickly.

BTW: with regards to adding the word Not in the box: I think that this is better than using the ! sign, but it might be still confusing as it feels like this is part of the text Common Namespace - any chance to use a different format; maybe bold, or change the color so it will be more highlighted?

[jpinsonneau]

BTW: with regards to adding the word Not in the box: I think that this is better than using the ! sign, but it might be still confusing as it feels like this is part of the text Common Namespace - any chance to use a different format; maybe bold, or change the color so it will be more highlighted?

The Not mention is currently used with quick filters but I agree we can improve that.

I feel icons could do the job:

Or custom ones:

[eranra]

BTW: with regards to adding the word Not in the box: I think that this is better than using the ! sign, but it might be still confusing as it feels like this is part of the text Common Namespace - any chance to use a different format; maybe bold, or change the color so it will be more highlighted?

The Not mention is currently used with quick filters but I agree we can improve that.

I feel icons could do the job:

Or custom ones:

Yes :-) This will look really good :+1

[jpinsonneau]

Created a followup for custom icons
https://issues.redhat.com/browse/NETOBSERV-1071

[jotak]

two small comments, else this lgtm

[jotak]

/lgtm
thanks @jpinsonneau !

[jpinsonneau]

merging this as we discussed today in sprint planning

[jpinsonneau]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jpinsonneau]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment