-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-387 UI: filter "NOT" #333
Conversation
Codecov Report
@@ Coverage Diff @@
## main #333 +/- ##
==========================================
- Coverage 58.08% 55.39% -2.69%
==========================================
Files 149 29 -120
Lines 6615 1753 -4862
Branches 792 0 -792
==========================================
- Hits 3842 971 -2871
+ Misses 2556 694 -1862
+ Partials 217 88 -129
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Looks good |
@jpinsonneau, this looks very good. Thanks for getting this done so quickly. BTW: with regards to adding the word |
The |
Yes :-) This will look really good :+1 |
Created a followup for custom icons |
two small comments, else this lgtm |
/lgtm |
merging this as we discussed today in sprint planning |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR implement
![image](https://private-user-images.githubusercontent.com/91894519/240598131-f2463689-5ce1-4231-bf03-3870dbca61f1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0NjU4MTIsIm5iZiI6MTcyNDQ2NTUxMiwicGF0aCI6Ii85MTg5NDUxOS8yNDA1OTgxMzEtZjI0NjM2ODktNWNlMS00MjMxLWJmMDMtMzg3MGRiY2E2MWYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDAyMTE1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIzZGZiOGNhY2NhMGVlM2RiYTdkN2VlMjNiZGZkYjUyYjJlNzM1Y2RkNGJiYTA4NDFiMzkwMDlmODliYmMzYjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Fp_nlugNyi2qMmzcA8q7EQOqsc9hWR6u9LNo_n57ISE)
equal
/not equal
dropdown between filter key and value:Clicking directly in the compare symbol switch from one to another
![image](https://private-user-images.githubusercontent.com/91894519/240598450-ae2930a7-c7cb-4cda-8c2b-3bcdb9d9f31f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0NjU4MTIsIm5iZiI6MTcyNDQ2NTUxMiwicGF0aCI6Ii85MTg5NDUxOS8yNDA1OTg0NTAtYWUyOTMwYTctYzdjYi00Y2RhLThjMmItM2JjZGI5ZDlmMzFmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDAyMTE1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYzYmRjZDY5NGMyOWJjZWQzYmMzZWMxOTFmZDgzODMwYmRhYzc4MGZjYzRkN2I3ODUzM2FkYTRiZWIwZmVkMjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.6WX6MPa3IhZFuW2OZC0zG29ENGh-8su0Pr0t1i1o5RI)
![image](https://private-user-images.githubusercontent.com/91894519/240598480-4280fa82-ba52-4b57-8cce-290e1b1a2f04.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0NjU4MTIsIm5iZiI6MTcyNDQ2NTUxMiwicGF0aCI6Ii85MTg5NDUxOS8yNDA1OTg0ODAtNDI4MGZhODItYmE1Mi00YjU3LThjY2UtMjkwZTFiMWEyZjA0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDAyMTE1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM2ZWI0OWI3MjY3MDA2OGNmZWY3M2Q1YWE2YzBkODc2YmU3NmE2MzBjMzFiMTk0YTk3NDI4Y2FkYTNkNjRlMTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.HQIcjzP28lKE2C2YsToGU2XzJgWmVxQJ4NZmDCU7G6I)
Once the proper comparaison is selected, you can type your filter as usual and see the result:
![image](https://private-user-images.githubusercontent.com/91894519/240598737-cbad316a-5633-4878-8665-9882d7e43d69.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0NjU4MTIsIm5iZiI6MTcyNDQ2NTUxMiwicGF0aCI6Ii85MTg5NDUxOS8yNDA1OTg3MzctY2JhZDMxNmEtNTYzMy00ODc4LTg2NjUtOTg4MmQ3ZTQzZDY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDAyMTE1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJhMjgzOWFiNTRiNDg1NGI2OTNlZTkyM2M3NjAxZTk2MGEyMmM3ZmNkMTRhN2ZlOWQxNDdmZjJiYTBiZWE3ZDcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ldn34unD-RDzmp-gFv0qg_wRoQqk_rHL_yJNSxYtprA)
Solve #328