Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to overview div #335

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

Amoghrd
Copy link
Contributor

@Amoghrd Amoghrd commented Jun 1, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #335 (2af6959) into main (8a60339) will not change coverage.
The diff coverage is n/a.

❗ Current head 2af6959 differs from pull request most recent head 1b2e4fe. Consider uploading reports for the commit 1b2e4fe to get more accurate results

@@           Coverage Diff           @@
##             main     #335   +/-   ##
=======================================
  Coverage   57.83%   57.83%           
=======================================
  Files         150      150           
  Lines        6652     6652           
  Branches      795      795           
=======================================
  Hits         3847     3847           
  Misses       2588     2588           
  Partials      217      217           
Flag Coverage Δ
uitests 58.77% <ø> (ø)
unittests 55.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/metrics/metrics-content.tsx 100.00% <ø> (ø)

@Amoghrd
Copy link
Contributor Author

Amoghrd commented Jun 1, 2023

/assign @jpinsonneau

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @Amoghrd !

@openshift-ci openshift-ci bot added the lgtm label Jun 2, 2023
@jpinsonneau
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit f01f7f9 into netobserv:main Jun 2, 2023
6 checks passed
@Amoghrd Amoghrd deleted the overview-metrics branch June 2, 2023 12:57
@Amoghrd
Copy link
Contributor Author

Amoghrd commented Jun 2, 2023

Should we backport this to 1.3 release branch?
If not, will have to wait for 1.4 downstream builds to get this PR in the next downstream build right?

@jpinsonneau
Copy link
Contributor

yes this has to be backported to have it in 1.3. I'm fine with that !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants