Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add length to metrics #338

Merged

Conversation

Amoghrd
Copy link
Contributor

@Amoghrd Amoghrd commented Jun 8, 2023

Show metrics length in data-test-metrics attribute

@Amoghrd
Copy link
Contributor Author

Amoghrd commented Jun 8, 2023

/assign @jpinsonneau

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #338 (a050a9e) into main (c855cf2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   57.87%   57.87%           
=======================================
  Files         150      150           
  Lines        6657     6657           
  Branches      797      797           
=======================================
  Hits         3853     3853           
  Misses       2588     2588           
  Partials      216      216           
Flag Coverage Δ
uitests 58.83% <ø> (ø)
unittests 55.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/metrics/metrics-content.tsx 100.00% <ø> (ø)
web/src/components/metrics/stat-donut.tsx 67.50% <ø> (ø)

@jpinsonneau
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 9, 2023
@jpinsonneau
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit 32dd09a into netobserv:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants