Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1090: initialize empty slice for returning json #340

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Jun 8, 2023

No description provided.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 8, 2023

@jotak: This pull request references NETOBSERV-1090 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 8, 2023
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

New image: quay.io/netobserv/network-observability-console-plugin:ca5277f. It will expire after two weeks.

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #340 (67ebabb) into main (c855cf2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   57.87%   57.88%           
=======================================
  Files         150      150           
  Lines        6657     6658    +1     
  Branches      797      797           
=======================================
+ Hits         3853     3854    +1     
  Misses       2588     2588           
  Partials      216      216           
Flag Coverage Δ
uitests 58.83% <ø> (ø)
unittests 55.21% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/utils.go 72.50% <100.00%> (+0.70%) ⬆️

@jotak jotak added the no-doc This PR doesn't require documentation change on the NetObserv operator label Jun 8, 2023
@jpinsonneau
Copy link
Contributor

/lgtm

@Amoghrd
Copy link
Contributor

Amoghrd commented Jun 20, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Jun 20, 2023
@jotak
Copy link
Member Author

jotak commented Jun 20, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 38f4cfc into netobserv:main Jun 20, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference lgtm no-doc This PR doesn't require documentation change on the NetObserv operator ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants