-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1098: Show scope as slider #344
Conversation
Opening as draft for now - we may clean the Slider component more to keep only what we need |
Codecov Report
@@ Coverage Diff @@
## main #344 +/- ##
==========================================
- Coverage 58.51% 56.88% -1.63%
==========================================
Files 158 162 +4
Lines 7097 7337 +240
Branches 868 902 +34
==========================================
+ Hits 4153 4174 +21
- Misses 2698 2917 +219
Partials 246 246
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@jotak: This pull request references NETOBSERV-1098 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jotak: This pull request references NETOBSERV-1098 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d2c3e61
to
7634e18
Compare
@jpinsonneau @andrew-ronaldson @stleerh This is ready for review.
But given how useful this is, tbh, if we don't find any blocking issue / regression, I'd be in favour of merging & iterating via a follow-up rather than holding for potentially a long time. About the Slider component included in this PR, it's copied from PF and slightly amended, in 2 different commits so that we can retrieve the diff & rebase more easily from upstream when needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For information, I opened an enhancement request on patternfly for an upstream (and clean) vertical slider implementation: https://github.com/orgs/patternfly/discussions/5775 |
/ok-to-test |
@jotak - image building is failing here with below error:
|
Borrow slider from patternfly, and adapt for vertical display
New changes are detected. LGTM label has been removed. |
@memodi yes, I didn't see, post-rebase issues, they should be fixed |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=a16f99f make set-plugin-image |
/label qe-approved |
hey @jpinsonneau are you ok with this plan: merge this and track the patternfly ticket for an upstream implementation? |
sure, as it's still possible to manage it in the advance options I don't think it's a blocker to merge as is 😉 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Borrow slider from patternfly, and adapt for vertical display