Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-997 Cypress test console errors #349

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

jpinsonneau
Copy link
Contributor

Since disabledFilters are loaded from local storage, it can be undefined at first start.

This PR simply ensure the object is initialized and avoid the error.

@jpinsonneau jpinsonneau requested review from jotak and memodi June 27, 2023 14:11
@memodi
Copy link
Contributor

memodi commented Jun 27, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 27, 2023
@github-actions
Copy link

New image: quay.io/netobserv/network-observability-console-plugin:fe3426a. It will expire after two weeks.

@memodi
Copy link
Contributor

memodi commented Jun 28, 2023

@jpinsonneau - this definitely yields better results along with my changes to have afterEach to reset-filters. https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/ocp-common/job/cypress-tests/11/console .

the only test there failed was for localStorage Plugin, which looks like issue NETOBSERV-967 , where when StartTime column went unselected when I hit on column save which is still a mystery to me.

@memodi
Copy link
Contributor

memodi commented Jun 28, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Jun 28, 2023
@jpinsonneau
Copy link
Contributor Author

Thanks @memodi ! Yeah the column selection is strange but definitely yet another bug 😸

@jotak
Copy link
Member

jotak commented Jun 28, 2023

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f37382e into netobserv:main Jun 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants