Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github ok-to-test: add more info in comment #353

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Jul 5, 2023

You can get a preview of it here: #352 (comment)

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #353 (5058007) into main (f37382e) will decrease coverage by 0.91%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   58.83%   57.92%   -0.91%     
==========================================
  Files         121      150      +29     
  Lines        4912     6665    +1753     
  Branches      797      797              
==========================================
+ Hits         2890     3861     +971     
- Misses       1894     2588     +694     
- Partials      128      216      +88     
Flag Coverage Δ
uitests 58.83% <ø> (ø)
unittests 55.39% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 29 files with indirect coverage changes

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @jotak

@jotak
Copy link
Member Author

jotak commented Jul 11, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants