-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade linter - fix found issues - use go1.20 #354
Conversation
@@ -1,27 +1,24 @@ | |||
linters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here, using the same config as in the operator. The removed modules were anyway disabled in golangci-lint
Codecov Report
@@ Coverage Diff @@
## main #354 +/- ##
=======================================
Coverage 58.05% 58.05%
=======================================
Files 151 151
Lines 6690 6690
Branches 800 800
=======================================
Hits 3884 3884
Misses 2589 2589
Partials 217 217
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.