Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade linter - fix found issues - use go1.20 #354

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Jul 12, 2023

No description provided.

@@ -1,27 +1,24 @@
linters:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, using the same config as in the operator. The removed modules were anyway disabled in golangci-lint

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #354 (32fb8ba) into main (d22f0ed) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main     #354   +/-   ##
=======================================
  Coverage   58.05%   58.05%           
=======================================
  Files         151      151           
  Lines        6690     6690           
  Branches      800      800           
=======================================
  Hits         3884     3884           
  Misses       2589     2589           
  Partials      217      217           
Flag Coverage Δ
uitests 59.00% <ø> (ø)
unittests 55.39% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/handler/csv/loki_csv.go 0.00% <0.00%> (ø)
pkg/handler/status.go 40.00% <100.00%> (ø)
pkg/kubernetes/auth/check_auth.go 85.24% <100.00%> (ø)

Copy link
Collaborator

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jotak
Copy link
Member Author

jotak commented Jul 13, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 575ea20 into netobserv:main Jul 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants