Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1197: Generalize TCPDrop to include more protocols #357

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jul 17, 2023

image

image

image

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #357 (0232616) into main (e6d08c3) will decrease coverage by 1.22%.
The diff coverage is 56.00%.

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   58.61%   57.39%   -1.22%     
==========================================
  Files         151      155       +4     
  Lines        6635     7065     +430     
  Branches      804      863      +59     
==========================================
+ Hits         3889     4055     +166     
- Misses       2524     2768     +244     
- Partials      222      242      +20     
Flag Coverage Δ
uitests 59.06% <66.45%> (+0.14%) ⬆️
unittests 52.71% <37.07%> (-5.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/handler/lokiclientmock/loki_client_mock.go 0.00% <0.00%> (ø)
pkg/model/fields/fields.go 100.00% <ø> (ø)
web/src/api/ipfix.ts 100.00% <ø> (ø)
web/src/api/loki.ts 100.00% <ø> (ø)
web/src/components/__tests-data__/config.ts 100.00% <ø> (ø)
...components/dropdowns/overview-display-dropdown.tsx 68.42% <ø> (ø)
web/src/components/dropdowns/scope-dropdown.tsx 31.81% <ø> (ø)
...components/dropdowns/topology-display-dropdown.tsx 47.36% <ø> (ø)
web/src/components/filters/filters-toolbar.tsx 59.18% <ø> (ø)
web/src/components/metrics/histogram.tsx 16.51% <ø> (ø)
... and 42 more

... and 1 file with indirect coverage changes

@github-actions
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:5a14402

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=5a14402 make set-plugin-image

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023
@github-actions
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:9148c55

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=9148c55 make set-plugin-image

@msherif1234 msherif1234 changed the title Generalize TCPDrop to include more protocols NETOBSERV-1197: Generalize TCPDrop to include more protocols Jul 17, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 17, 2023

@msherif1234: This pull request references NETOBSERV-1197 which is a valid jira issue.

In response to this:

image

image

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jotak
Copy link
Member

jotak commented Jul 19, 2023

/lgtm

@msherif1234
Copy link
Contributor Author

/approve

1 similar comment
@jotak
Copy link
Member

jotak commented Jul 19, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak, msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 76b65ff into netobserv:main Jul 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants