-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention 'dropped by the kernel' #358
Conversation
jotak
commented
Jul 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #358 +/- ##
==========================================
- Coverage 57.97% 57.93% -0.05%
==========================================
Files 154 159 +5
Lines 6994 7168 +174
Branches 863 868 +5
==========================================
+ Hits 4055 4153 +98
- Misses 2697 2769 +72
- Partials 242 246 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -234,7 +234,7 @@ export const QueryOptionsPanel: React.FC<QueryOptionsDropdownProps> = ({ | |||
<Tooltip | |||
content={ | |||
<div> | |||
<div>{t('Flows drops to query')}:</div> | |||
<div>{t('Filter flows by their drop status. Only packets dropped by the kernel are monitored here.')}</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do u need // eslint-disable-next-line max-len
?
web/src/utils/overview-panels.ts
Outdated
}; | ||
case 'top_dropped_bar_total': | ||
return { | ||
title: t('Top {{limit}} {{type}} dropped rates stacked with total', { limit, type }), | ||
chartType: t('bars'), | ||
tooltip: t('The top dropped rates as bar compared to total as line over the selected interval') | ||
tooltip: t('The top dropped rates (dropped by the kernel) as bar compared to total as line over the selected interval') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably here too ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was a formatting issue .. running make fmt
fixed it, PR updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |