Mention 'dropped by the kernel' #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jotak
commented
Jul 18, 2023
jotak
commented
Codecov Report
@@ Coverage Diff @@
## main #358 +/- ##
==========================================
- Coverage 57.97% 57.93% -0.05%
==========================================
Files 154 159 +5
Lines 6994 7168 +174
Branches 863 868 +5
==========================================
+ Hits 4055 4153 +98
- Misses 2697 2769 +72
- Partials 242 246 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
msherif1234
reviewed
Jul 18, 2023
| @@ -234,7 +234,7 @@ export const QueryOptionsPanel: React.FC<QueryOptionsDropdownProps> = ({ | |||
| <Tooltip | |||
| content={ | |||
| <div> | |||
| <div>{t('Flows drops to query')}:</div> | |||
| <div>{t('Filter flows by their drop status. Only packets dropped by the kernel are monitored here.')}</div> | |||
There was a problem hiding this comment.
do u need // eslint-disable-next-line max-len ?
msherif1234
reviewed
Jul 18, 2023
web/src/utils/overview-panels.ts
Outdated
| }; | ||
| case 'top_dropped_bar_total': | ||
| return { | ||
| title: t('Top {{limit}} {{type}} dropped rates stacked with total', { limit, type }), | ||
| chartType: t('bars'), | ||
| tooltip: t('The top dropped rates as bar compared to total as line over the selected interval') | ||
| tooltip: t('The top dropped rates (dropped by the kernel) as bar compared to total as line over the selected interval') |
There was a problem hiding this comment.
it was a formatting issue .. running make fmt fixed it, PR updated
jotak
added
no-qe
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.