Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1200: Show "< 1ms" for 0 latency instead of n/a #360

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Jul 21, 2023

image

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 21, 2023

@jotak: This pull request references NETOBSERV-1200 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #360 (7dbb6f0) into main (56386e8) will decrease coverage by 0.02%.
The diff coverage is 57.66%.

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
- Coverage   57.97%   57.96%   -0.02%     
==========================================
  Files         154      159       +5     
  Lines        6994     7168     +174     
  Branches      863      868       +5     
==========================================
+ Hits         4055     4155     +100     
- Misses       2697     2767      +70     
- Partials      242      246       +4     
Flag Coverage Δ
uitests 59.80% <57.66%> (+0.73%) ⬆️
unittests 52.71% <ø> (-2.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/__tests-data__/flows.ts 100.00% <ø> (ø)
...components/netflow-topology/2d/components/edge.tsx 35.71% <ø> (ø)
...c/components/netflow-topology/netflow-topology.tsx 67.74% <0.00%> (-2.26%) ⬇️
...omponents/netflow-topology/2d/topology-content.tsx 28.42% <12.50%> (-0.37%) ⬇️
web/src/components/netflow-tab.tsx 50.00% <22.22%> (ø)
web/src/model/topology.ts 32.79% <25.00%> (-0.36%) ⬇️
...nts/netflow-topology/2d/styles/styleDecorators.tsx 26.82% <26.82%> (ø)
...omponents/netflow-topology/2d/styles/styleNode.tsx 31.11% <28.57%> (+1.94%) ⬆️
...ents/netflow-topology/2d/styles/styleDecorator.tsx 38.46% <38.46%> (ø)
web/src/model/filters.ts 70.37% <42.85%> (+6.73%) ⬆️
... and 12 more

... and 4 files with indirect coverage changes

@msherif1234
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 21, 2023

@jotak: This pull request references NETOBSERV-1200 which is a valid jira issue.

In response to this:

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jotak jotak changed the title NETOBSERV-1200: Show 0 ms latency instead of n/a NETOBSERV-1200: Show < 1ms latency instead of n/a Jul 21, 2023
@jotak jotak changed the title NETOBSERV-1200: Show < 1ms latency instead of n/a NETOBSERV-1200: Show "< 1ms" for 0 latency instead of n/a Jul 21, 2023
@memodi
Copy link
Contributor

memodi commented Jul 21, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 21, 2023
@github-actions
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:43ec11c

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=43ec11c make set-plugin-image

@memodi
Copy link
Contributor

memodi commented Jul 21, 2023

/label qe-approved

image

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Jul 21, 2023
@msherif1234
Copy link
Contributor

/approve

1 similar comment
@jotak
Copy link
Member Author

jotak commented Jul 24, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak, msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2d13faa into netobserv:main Jul 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants