-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix filters comparison #363
Conversation
Filters comparison was broken in different ways: - Same filters with different ordering would be seen as different - Same filters with different *values* ordering would be seen as different - Same filters with different display info would be seen as different (when the page is refreshed, the display info on values isn't set) This commit fixes all of that, and adds tests for each of these scenarios
Codecov Report
@@ Coverage Diff @@
## main #363 +/- ##
==========================================
- Coverage 57.44% 56.94% -0.50%
==========================================
Files 161 162 +1
Lines 7266 7347 +81
Branches 902 902
==========================================
+ Hits 4174 4184 +10
- Misses 2846 2917 +71
Partials 246 246
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @jotak
NETOBSERV-1218 |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=ec8fb65 make set-plugin-image |
/label jira/valid-reference NETOBSERV-1218 |
/label qe-approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Filters comparison was broken in different ways:
This commit fixes all of that, and adds tests for each of these scenarios