NETOBSERV-970 Typo in Query Summary panel #368
Conversation
Codecov Report
@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 57.77% 57.29% -0.48%
==========================================
Files 166 167 +1
Lines 7659 7737 +78
Branches 915 917 +2
==========================================
+ Hits 4425 4433 +8
- Misses 2967 3038 +71
+ Partials 267 266 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -453,6 +452,7 @@ | |||
| "Specify a single DNS RCODE name like:": "Specify a single DNS RCODE name like:", | |||
| "A IANA RCODE number like 0, 3, 9": "A IANA RCODE number like 0, 3, 9", | |||
| "A IANA RCODE name like NoError, NXDomain, NotAuth": "A IANA RCODE name like NoError, NXDomain, NotAuth", | |||
| "P": "P", | |||
There was a problem hiding this comment.
what is P ? Packet(s) ? if so u changed it below from P to Packets then we probably need to do the same here too ?
There was a problem hiding this comment.
That's an autogenerated file 😃
However i18n is a bit dumb and sort translations by first found in sources.
'P' is still used in Overview page since we don't have room to write 'Packets' inside donuts so that's why it's still there but in another order
|
/ok-to-test |
1 similar comment
|
/ok-to-test |
msherif1234
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=d15182a make set-plugin-image |
|
/label qe-approved |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Here is my suggestion to fix the typo:
Flows,Packets)1k+ Flows,1k+ Packets) and kept after for others (757+ MB,2.52+ MBps)