NETOBSERV-1135: add ovs subsystem drop causes #370
Conversation
|
@msherif1234: This pull request references NETOBSERV-1135 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #370 +/- ##
==========================================
- Coverage 57.83% 57.30% -0.54%
==========================================
Files 166 167 +1
Lines 7672 7750 +78
Branches 917 918 +1
==========================================
+ Hits 4437 4441 +4
- Misses 2968 3042 +74
Partials 267 267
Flags with carried forward coverage won't be shown. Click here to find out more.
|
msherif1234
force-pushed
the
ovs_drops
branch
9 times, most recently
from
bd19e20
to
44915f3
Compare
web/src/utils/pkt-drop.ts
Outdated
|
|
||
| export const getDropCauseDescription = (name: DROP_CAUSES_NAMES): string => { | ||
| return DROP_CAUSES.find(v => v.name === name)?.description || 'Unknown'; | ||
| }; | ||
|
|
||
| export const getDropCauseDocUrl = (name: DROP_CAUSES_NAMES): string => { | ||
| if (name.includes('OVS')) { |
There was a problem hiding this comment.
| if (name.includes('OVS')) { | |
| if (name.startsWith('OVS_')) { |
nit: would be safer to check start prefix including _
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
include ovs drops to console plugin